FIX false-success: opnsense-plugins.sh apply ALWAYS dry-ran (DRY_RUN:+ expands on 0)
Found on the first-ever live run (vr1-dc0 edge, 2026-07-20): ${DRY_RUN:+--dry-run}
expands whenever the var is set and NON-EMPTY, and DRY_RUN=0 is non-empty -- so
every apply silently dry-ran while printing 'OK: profile applied'. Nothing was
ever installed by this script. The harness missed it because every test drove
--dry-run, leaving the live path with zero coverage. Fix tests the VALUE; harness
gains two live-path tests via a stub api client (verified to FAIL 2/2 against the
buggy version before restoring). 20/20.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KiUu1oqt76tWvV4vEC3NAr
1 parent f5510c7 commit 24c6be145f4b5ca292b7459ce923b9885f4e5f9c
@JANeumatrix JANeumatrix authored 18 hours ago
Showing 3 changed files
View
docs/audit/d129-plugins-20260720.txt 0 → 100644
View
scripts/opnsense-plugins.sh
View
tests/opnsense-plugins/run-tests.sh