D-125 correction: uplink /24 is the ruled 172.30.2.0/24, not a HELD tfvar (no new NetBox object)
The initial D-125 records wrongly modeled the vcloud ISP /24 as a NEW,
NetBox-assigned HELD value (`var.vr1_dc0_uplink_cidr`) with an OPNsense WAN
re-address. That is factually wrong: bridge-in is single-NAT, so there is
exactly ONE simulated-ISP /24 for vr1-dc0, and D-115 already ruled it
(172.30.2.0/24, role edge, site vr1-dc0). NetBox models the prefix by role+site
and does not care which libvirt host runs the NAT, so the /24's IPAM identity is
UNCHANGED from Model A; only the libvirt realization moved (a vcloud NAT bridged
through vvr1-dc0). OPNsense WAN stays .2. (Caught reconciling the "create netbox
objects" request against dc-edge-wan-import.py, which already registers this /24.)

- opentofu/main.tf: module vr1_dc0_uplink cidr = "172.30.2.0/24" inlined (ruled
  literal, matching the inner root's site-wan pattern) instead of the var.
- opentofu/variables.tf: REMOVED variable vr1_dc0_uplink_cidr (replaced with a
  note explaining why it is a ruled literal, not a tfvar).
- Records corrected everywhere the false claim propagated: D-125 body + D-122
  amendment, changelog-phaseC2-D125, model-a-fallback (B->A delta item 8 +
  revert), session-ledger, dc-dc-deployment-workflow, phase-2 runbook.

Net effect: D-125 adds NO new NetBox object and NO new HELD gate. The only
NetBox work left for the DC substrate is D-124's transit /30 + rack IP.

Both roots validate; gauntlet ALL GREEN (63); repo-lint 0 fail.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ck6xh3jWQi5b3Su8Dx1LEH
1 parent 4d490cf commit e2703252ab421d37bce0efb9e93d2c0cb616bca4
@JANeumatrix JANeumatrix authored 3 hours ago
Showing 9 changed files
View
docs/changelog-20260716-review-sweep-phaseC2-D125.md
View
docs/dc-dc-deployment-workflow.md
View
docs/design-decisions.md
View
docs/model-a-fallback-plan.md
View
docs/session-ledger.md
View
opentofu/main.tf
View
opentofu/variables.tf
View
opentofu/vr1-dc0-substrate/main.tf
View
runbooks/dc-dc-phase2-tofu-dc-substrate.md